vmmon: fix HostIF_SetFastClockRate() not to use force_sig()

mkubecek · mkubecek · commit 98008ff6adec · 2019-07-09T21:07:04.000+02:00
Commit 3cf5d076fb4d ("signal: Remove task parameter from force_sig") in
v5.3-rc1 drops second argument of force_sig(); before that, all callers
which passed something else than current task as second argument were
fixed, mostly to use send_sig() instead.

The situation in HostIF_SetFastClockRate() is the same as e.g. in bpfilter
call fixed by commit 1dfd1711de29 ("signal/bpfilter: Fix bpfilter_kernl to
use send_sig not force_sig"): locking in force_sig_info() cannot handle
task exiting and using force_sig() for SIGKILL is pointless anyway as this
signal cannot be blocked.

As send_sig() is present with unchanged signature since the pre-git era, we
can use send_sig() unconditionally, regardless of kernel version.
diff --git a/vmmon-only/linux/hostif.c b/vmmon-only/linux/hostif.c
@@ -3403,7 +3403,7 @@ HostIF_SetFastClockRate(unsigned int rate) // IN: Frequency in Hz.
       }
    } else {
       if (linuxState.fastClockThread) {
-         force_sig(SIGKILL, linuxState.fastClockThread);
+         send_sig(SIGKILL, linuxState.fastClockThread, 1);
          kthread_stop(linuxState.fastClockThread);
 
          linuxState.fastClockThread = NULL;

Original file line number	Diff line number	Diff line change
`@@ -3403,7 +3403,7 @@ HostIF_SetFastClockRate(unsigned int rate) // IN: Frequency in Hz.`
`3403`	`3403`	`}`
`3404`	`3404`	`} else {`
`3405`	`3405`	`if (linuxState.fastClockThread) {`
`3406`		`- force_sig(SIGKILL, linuxState.fastClockThread);`
	`3406`	`+ send_sig(SIGKILL, linuxState.fastClockThread, 1);`
`3407`	`3407`	`kthread_stop(linuxState.fastClockThread);`
`3408`	`3408`
`3409`	`3409`	`linuxState.fastClockThread = NULL;`